Upgrade polkadot sdk to `stable2412-4` (rel. `1.5.0`) by pandres95 · Pull Request #606 · polkadot-fellows/runtimes

pandres95 · 2025-02-25T07:00:11Z

This Pull Request provides a minimal set of changes to support the upgrade to stable2412 (to the latest available patch).

Notable changes

Here are the most notable changes:

sp-std removed for every runtime (except Encointer). Now we use core or alloc instead.
Mocked weights for frame_system_extensions, pallet_transaction_payment, and xcm on most runtimes.
Mocked weights for pallet_identity on People runtimes.
Update to XCMv5 started.

Notable TODOs

~~Review whether we need to make more changes regarding XCMv5~~ (moved to a follow-up PR). @franciscoaguirre
In Asset Hubs, the benchmarking options for pallet-asset-conversion-tx-payment is not exposed (or at least, is raising errors when trying to add it).
For polkadot-runtime, do we still need coretime_migration.rs? @seadanda
Assist with the initial implementation of TransactionExtension @georgepisaltu @gui1117

Open Question

Shouldn't we start using frame, #[frame_construct_runtime] and #[derive_impl] since they've already been proven to work?

Help needed

@clangenb to update and re-enable Encointer.

Action List

~~Remove any reference to either NetworkId::Westend and NetworkId::Rococo and replace with NetworkId::ByGenesis~~ (moved to a follow-up PR).
Upgrade to stable2412-3
Setup filter for pallet-staking to exclude pool members. See comment here.

Follow-up PRs

Refresh weights (to do before this release). ;)
Move storage for ForeignAssets and AssetConversion to XCMv5.
Remove sp-std.

@clangenb

Note: This had to be done since there are not updated pallets that could be used for upgrading the runtime. TODO @clangenb: Help updating Encointer to `stable2412`.

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed. Note 4: do we still need `coretime_migration.rs`?

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.

Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed

Note: includes mocked weights, needs to run proper benches. Note 3: `sp_std` was removed

Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed

clangenb · 2025-02-25T07:49:09Z

@pandres95 on-it. I reckon to have a PR by Thursday, the latest.

# Conflicts: # relay/kusama/src/lib.rs # relay/polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/lib.rs # system-parachains/collectives/collectives-polkadot/src/lib.rs # system-parachains/coretime/coretime-kusama/src/lib.rs # system-parachains/coretime/coretime-polkadot/src/lib.rs # system-parachains/gluttons/glutton-kusama/src/lib.rs # system-parachains/people/people-kusama/src/lib.rs # system-parachains/people/people-polkadot/src/lib.rs

clangenb · 2025-02-25T14:30:09Z

encointer is ready: pandres95#9

* Revert "feat(encointer-kusama-runtime): disable Encointer runtime and pallets." This reverts commit 9303cb3 * bump encointer crates * migrate encointer runtime to stable202412-2 * [encointer] add benchmarking setup for asset_tx_payment * [encointer] fix asset-tx-benchmarks * fmt * remove sp-std from encointer * fix pallet-transaction payment feature propagation

seadanda · 2025-02-25T17:22:34Z

Closes #552

Polkadot migration cleanup: pandres95#10

bkontur · 2025-04-16T11:15:06Z

@pepoviola zombienet-smoke test does not start progressing:
https://github.com/polkadot-fellows/runtimes/actions/runs/14489755127/job/40643253645?pr=606#step:10:459

test smoke has been running for over 60 seconds
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.

It is nothing like before: https://github.com/polkadot-fellows/runtimes/actions/runs/14001583911/job/39208932124

running 1 test
2025-03-21T22:14:27.629319Z  INFO smoke: Using zombienet provider: Docker

Could there something specific with stable2412 for zombienet?

bkontur · 2025-04-16T11:30:05Z

+		_descendant_origin: &Option<InteriorLocation>,
+		_xcm: &Xcm<RuntimeCall>,
+	) -> Weight {
+		XcmGeneric::<Runtime>::execute_with_origin()


@franciscoaguirre shouldn't we disable this everywhere? or remove execute_with_origin?

We removed it from the executor anyway. If someone tries to use it it'll just return an error

aha, ok, I see that patch is here: so the benchmarking will return Weight::MAX right?

* fix(polkadot-runtime): pallet-xcm-benchmarks * fix(polkadot-runtime): increate worst case holding

bkontur · 2025-04-16T14:27:06Z

@pepoviola zombienet-smoke test does not start progressing: https://github.com/polkadot-fellows/runtimes/actions/runs/14489755127/job/40643253645?pr=606#step:10:459
test smoke has been running for over 60 seconds
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.
It is nothing like before: https://github.com/polkadot-fellows/runtimes/actions/runs/14001583911/job/39208932124
running 1 test
2025-03-21T22:14:27.629319Z  INFO smoke: Using zombienet provider: Docker
Could there something specific with stable2412 for zombienet?

Trying some nits here for zombienet smoke: pandres95#24

bkontur · 2025-04-16T16:56:45Z

@pepoviola zombienet-smoke test does not start progressing: https://github.com/polkadot-fellows/runtimes/actions/runs/14489755127/job/40643253645?pr=606#step:10:459
test smoke has been running for over 60 seconds
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.
It is nothing like before: https://github.com/polkadot-fellows/runtimes/actions/runs/14001583911/job/39208932124
running 1 test
2025-03-21T22:14:27.629319Z  INFO smoke: Using zombienet provider: Docker
Could there something specific with stable2412 for zombienet?
Trying some nits here for zombienet smoke: pandres95#24

@pepoviola I don't know why, but zombienet smoke test is flaky, I tried coretime-polkadot and previous version with some cumulus based parachain, and it does not produce blocks for parachain:
https://github.com/pandres95/runtimes/actions/runs/14496644330/job/40666016974?pr=24

[2025-04-16T15:52:56Z INFO  smoke] Block #8
[2025-04-16T15:53:04Z INFO  smoke] Block #9
[2025-04-16T15:53:04Z INFO  smoke] Parachain Block #0
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

pandres95 · 2025-04-16T18:35:25Z

/merge

fellowship-merge-bot · 2025-04-16T18:41:40Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

pepoviola · 2025-04-16T21:32:34Z

@pepoviola zombienet-smoke test does not start progressing: https://github.com/polkadot-fellows/runtimes/actions/runs/14489755127/job/40643253645?pr=606#step:10:459
test smoke has been running for over 60 seconds
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.
It is nothing like before: https://github.com/polkadot-fellows/runtimes/actions/runs/14001583911/job/39208932124
running 1 test
2025-03-21T22:14:27.629319Z  INFO smoke: Using zombienet provider: Docker
Could there something specific with stable2412 for zombienet?
Trying some nits here for zombienet smoke: pandres95#24
@pepoviola I don't know why, but zombienet smoke test is flaky, I tried coretime-polkadot and previous version with some cumulus based parachain, and it does not produce blocks for parachain: https://github.com/pandres95/runtimes/actions/runs/14496644330/job/40666016974?pr=24
[2025-04-16T15:52:56Z INFO  smoke] Block #8
[2025-04-16T15:53:04Z INFO  smoke] Block #9
[2025-04-16T15:53:04Z INFO  smoke] Parachain Block #0
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.

That weird, can we increase the log (zombienet=debug) to get a more verbose output. I also will try locally.
Thx!

bkontur · 2025-04-17T08:41:37Z

@pepoviola zombienet-smoke test does not start progressing: https://github.com/polkadot-fellows/runtimes/actions/runs/14489755127/job/40643253645?pr=606#step:10:459
test smoke has been running for over 60 seconds
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.
It is nothing like before: https://github.com/polkadot-fellows/runtimes/actions/runs/14001583911/job/39208932124
running 1 test
2025-03-21T22:14:27.629319Z  INFO smoke: Using zombienet provider: Docker
Could there something specific with stable2412 for zombienet?
Trying some nits here for zombienet smoke: pandres95#24
@pepoviola I don't know why, but zombienet smoke test is flaky, I tried coretime-polkadot and previous version with some cumulus based parachain, and it does not produce blocks for parachain: https://github.com/pandres95/runtimes/actions/runs/14496644330/job/40666016974?pr=24
[2025-04-16T15:52:56Z INFO  smoke] Block #8
[2025-04-16T15:53:04Z INFO  smoke] Block #9
[2025-04-16T15:53:04Z INFO  smoke] Parachain Block #0
Error: The action 'Zombienet smoke test' has timed out after 20 minutes.
That weird, can we increase the log (zombienet=debug) to get a more verbose output. I also will try locally. Thx!

@pepoviola I changed the logs, but let's please continue discussion/fixing here: #676

This is leftover from bump stable2412 where we added Aliasers but not changed weights: #606 for AssetHub weights were fixed here #700 but not for other chains - [X] Does not require a CHANGELOG entry

pandres95 added 15 commits February 24, 2025 23:17

chore: update dependencies to stable2412-1

90fa616

feat(encointer-kusama-runtime): disable Encointer runtime and pallets.

9303cb3

Note: This had to be done since there are not updated pallets that could be used for upgrading the runtime. TODO @clangenb: Help updating Encointer to `stable2412`.

feat(staging-kusama-runtime): adapt runtime to stable2412.

8f2a13d

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.

feat(polkadot-runtime): adapt runtime to stable2412.

c4ffd30

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed. Note 4: do we still need `coretime_migration.rs`?

feat(asset-hub-kusama-runtime): adapt runtime to stable2412.

baf0ce8

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.

feat(asset-hub-polkadot-runtime): adapt runtime to stable2412.

f09d366

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.

feat(bridge-hub-kusama-runtime): adapt runtime to stable2412.

280ad15

Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed

feat(bridge-hub-polkadot-runtime): adapt runtime to stable2412.

a7816b3

Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed

feat(collectives-polkadot-runtime): adapt runtime to stable2412.

cd29ea3

Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed

feat(coretime-kusama-runtime): adapt runtime to stable2412.

caae9a6

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed

feat(coretime-polkadot-runtime): adapt runtime to stable2412.

e36bb9e

Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed

feat(glutton-kusama-runtime): adapt runtime to stable2412.

6003830

Note: includes mocked weights, needs to run proper benches. Note 3: `sp_std` was removed

feat(people-kusama-runtime): adapt runtime to stable2412.

a047273

Note: includes mocked weights, needs to run proper benches. Note 3: `sp_std` was removed

feat(people-polkadot-runtime): adapt runtime to stable2412.

8469c13

Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed

chore: update CHANGELOG.md

b1d82e6

pandres95 changed the title ~~Upgrade polkadot sdk to stable2412~~ Upgrade polkadot sdk to stable2412-1 Feb 25, 2025

pandres95 added 2 commits February 25, 2025 03:36

fix: fmt CHANGELOG.md

e4fd702

seadanda and others added 3 commits February 25, 2025 13:16

Remove coretime migrations from Polkadot (#10)

fae7bfb

fix: zepter missing feature propagations

4283460

fix: fmt

0471653